-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support get all host address(#489) #491
Conversation
Hi, thanks for your contribution, could you please sign the CLA first? |
已经登录了呀
…------------------ 原始邮件 ------------------
发件人: ***@***.***>;
发送时间: 2022年11月16日(星期三) 中午11:06
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [vesoft-inc/nebula-java] fix: support get all host address(#489) (PR #491)
Hi, thanks for your contribution, could you please sign the CLA first?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
似乎是单测环境不支持语句了?能否帮忙检查下 @Nicole00 |
maybe you should re-push your pr after sign cla. |
我是否应该提PR到master分支,而不是我们项目使用的版本2.5.1,第一次PR的过程总是问题很多 😁 @Nicole00 |
Sorry, I missed the base branch information. Yeah, you should push your |
Codecov ReportBase: 63.18% // Head: 63.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
============================================
- Coverage 63.18% 63.12% -0.07%
Complexity 781 781
============================================
Files 71 71
Lines 3746 3748 +2
Branches 536 537 +1
============================================
- Hits 2367 2366 -1
- Misses 1012 1015 +3
Partials 367 367
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
you should config your email for your github account. |
It seems that we need two conditions to fulfill:
looks like the email address doesn't match the GitHub user? @chenzuyibao you could try change comment authors and push force, or if you are not familiar with them, you could create another local branch locally, apply file changes to new branch and commit with the expected author name and email.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #489
支持域名解析所有IP地址