Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cast params #349

Merged
merged 12 commits into from
May 29, 2024
Merged

feat: cast params #349

merged 12 commits into from
May 29, 2024

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented May 27, 2024

To cast param map from primitive to thrift bytes

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #273

@wey-gu wey-gu changed the title feat: cast params feat: cast params(WIP) May 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (08e6e93) to head (954f33a).
Report is 1 commits behind head on master.

Files Patch % Lines
nebula3/gclient/net/base.py 52.63% 18 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   75.36%   75.02%   -0.34%     
==========================================
  Files          19       19              
  Lines        2667     2707      +40     
==========================================
+ Hits         2010     2031      +21     
- Misses        657      676      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wey-gu
Copy link
Contributor Author

wey-gu commented May 27, 2024

  • coverage
  • example/docs

@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label May 28, 2024
@BeautyyuYanli
Copy link
Contributor

BeautyyuYanli commented May 28, 2024

Some changes:

  • method BaseExecutor.execute_py_params to use this feature
  • not support list and dict yet

@wey-gu
Copy link
Contributor Author

wey-gu commented May 28, 2024

Some changes:

  • method BaseExecutor.execute_py_params to use this feature

  • not support list and dict yet

It's fair to separate the two for performance concern 👍.

But why not support List? That's actually my initial motivation of such change😋😂

@BeautyyuYanli
Copy link
Contributor

But why not support List? That's actually my initial motivation of such change😋😂

The current usage for NList is wrong and I do not yet find the correct way to use NList

@wey-gu
Copy link
Contributor Author

wey-gu commented May 28, 2024

Aha, got it, :-p

Should be somewhere I made it wrong, but this was verified working, I'll continue this part later when I have some time.

@BeautyyuYanli
Copy link
Contributor

fixed NList

@wey-gu wey-gu changed the title feat: cast params(WIP) feat: cast params May 28, 2024
@wey-gu wey-gu requested a review from Nicole00 May 28, 2024 13:36
@Nicole00 Nicole00 merged commit 6672e51 into master May 29, 2024
10 checks passed
@Nicole00 Nicole00 deleted the param_cast branch May 29, 2024 02:47
wey-gu added a commit that referenced this pull request Jul 16, 2024
* feat: cast params

#273

* handle None of params

* lint: make black happy

* docs and example added with UT coverage

* docs of result set as primitive

* fix structure to make the cast non-breaking (#350)

* make linter happy

* minor fix

* remove list cast

* fix NList usage

* fix test

* chore: polish readme

---------

Co-authored-by: 盐粒 Yanli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants