-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cast params #349
feat: cast params #349
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 75.36% 75.02% -0.34%
==========================================
Files 19 19
Lines 2667 2707 +40
==========================================
+ Hits 2010 2031 +21
- Misses 657 676 +19 ☔ View full report in Codecov by Sentry. |
|
Some changes:
|
It's fair to separate the two for performance concern 👍. But why not support List? That's actually my initial motivation of such change😋😂 |
The current usage for NList is wrong and I do not yet find the correct way to use NList |
Aha, got it, :-p Should be somewhere I made it wrong, but this was verified working, I'll continue this part later when I have some time. |
fixed NList |
* feat: cast params #273 * handle None of params * lint: make black happy * docs and example added with UT coverage * docs of result set as primitive * fix structure to make the cast non-breaking (#350) * make linter happy * minor fix * remove list cast * fix NList usage * fix test * chore: polish readme --------- Co-authored-by: 盐粒 Yanli <[email protected]>
To cast param map from primitive to thrift bytes
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #273