Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify subgraph loop condition #4226

Merged
merged 2 commits into from
May 6, 2022
Merged

modify subgraph loop condition #4226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b9462
modify loop condition
nevermore3 May 5, 2022
334059d
fix error
nevermore3 May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/graph/planner/ngql/SubgraphPlanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,11 @@ StatusOr<SubPlan> SubgraphPlanner::nSteps(SubPlan& startVidPlan, const std::stri
subgraph->setOutputVar(input);
subgraph->setBiDirectEdgeTypes(subgraphCtx_->biDirectEdgeTypes);
subgraph->setColNames({nebula::kVid});

auto* condition = loopCondition(steps.steps() + 1, gn->outputVar());
uint32_t maxSteps = steps.steps();
if (subgraphCtx_->getEdgeProp || subgraphCtx_->withProp) {
++maxSteps;
}
Comment on lines +78 to +81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does taking properties have to do with the max step of loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getEdgeProp just indicates whether to output the edge。will fix name, avoid ambiguity

auto* condition = loopCondition(maxSteps, gn->outputVar());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps of subgraph executor don't keep same with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no effect

auto* loop = Loop::make(qctx, startVidPlan.root, subgraph, condition);

auto* dc = DataCollect::make(qctx, DataCollect::DCKind::kSubgraph);
Expand Down