-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stats log print to console when we start process. #4550
Fix stats log print to console when we start process. #4550
Conversation
we before setLogging, init our stats, when we adjust high level verbose log. it will be output logs to console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for your contribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4550 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.03%
==========================================
Files 1354 1355 +1
Lines 134943 135012 +69
==========================================
+ Hits 114261 114365 +104
+ Misses 20682 20647 -35 ☔ View full report in Codecov by Sentry. |
we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: I do not pull new issue for this.
Description:
we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.
How do you solve it?
I adjust the init stats order from main process in Metad and Storaged
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: