feat: add support for KafkaDependentProducer instrumentation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vhatsura I also noticed that snapshots for the current tests are not matching but I'll wait for CI to run as it is not related to my changes. |
overbit
force-pushed
the
add-support-dependent-producer
branch
from
24f7b13 to
60d54c0
Compare
overbit
changed the title
|
Hi, @overbit Thanks for your contribution. To be honest, I didn't know about The issue with mismatched snapshots caused by tests for dependent produce as they are writing messages into the same topics as other tests. If you specify the different topic name, the tests should be passed |
|
I'm going to bump up dependencies in follow-up PR, so, I'll regenerate snapshots there. |
vhatsura
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for KafkaDependentProducer that allows to produce messages with different types using a single producer instance.
Using KafkaDependentProducer is more efficient than creating more than one kafka producer instance.