Need small update for new pyglet (v2.1) to use shapes.Line function in pymunk.pyglet_util

[AkahoshiT]

width is disabled in new pyglet.shapes.Line and get warning if you run it.
So we need to replace width with thickness for newer version of pyglet.

pymunk/pymunk/pyglet_util.py

Lines 127 to 135 in 83052ce

	l = pyglet.shapes.Line(
	pos.x, pos.y, cc.x, cc.y, width=1, color=color, batch=self.batch, group=fg
	)
	self.draw_shapes.append(l)
	def draw_segment(self, a: Vec2d, b: Vec2d, color: SpaceDebugColor) -> None:
	c = color.as_int()
	l = pyglet.shapes.Line(a.x, a.y, b.x, b.y, width=1, color=c, batch=self.batch)
	self.draw_shapes.append(l)

        l = pyglet.shapes.Line(
            pos.x, pos.y, cc.x, cc.y, thickness=1, color=color, batch=self.batch, group=fg
        )
        self.draw_shapes.append(l)

    def draw_segment(self, a: Vec2d, b: Vec2d, color: SpaceDebugColor) -> None:
        c = color.as_int()
        l = pyglet.shapes.Line(a.x, a.y, b.x, b.y, thickness=1, color=c, batch=self.batch)
        self.draw_shapes.append(l)

[totex]

I had the same problem as @AkahoshiT, changing the "width" to "thickness" solved the problem.

But there is an another problem related to the problem above. If you create a DYNAMIC body, and add a shape to it:

circle_body = pymunk.Body(body_type=pymunk.Body.DYNAMIC)
circle_shape = pymunk.Circle(circle_body, radius=30)

This code results to the following error:
ValueError: cannot convert float NaN to integer

This error comes from the pyglet_util.DrawOptions

[viblo]

Thanks for the report!

As for the thickness.. Its easy to fix, but that breaks pyglet 2.0.x.. And I have already fallback code for pyglet 1.5, Im not so much into having 2 different fallbacks. But I guess it should be ok to break it This is only relevant if you use pyglet for something complicated and at the same time use debug draw.

At the same time, I think I can remove support for 1.5 now. (But maybe in a separate release), now a long time passed since 2.0 were released, and its difficult to think of cases were you need to both use latest pymunk but at the same time such an old pyglet version.

[viblo]

@totex Can you expand on your example? Both pyglet_util_demo and box2d_vertical_stack works so not sure what you do?

[totex]

@viblo Sorry, it looks like, I just forgot to create the body correctly.

I have created a DYNAMIC body without the mass and the moment, like this:
circle_body = pymunk.Body(body_type=pymunk.Body.DYNAMIC)

I tried it like this, and it works:
circle_body = pymunk.Body(1, 1666, body_type=pymunk.Body.DYNAMIC)

[viblo]

@viblo Sorry, it looks like, I just forgot to create the body correctly.

I have created a DYNAMIC body without the mass and the moment, like this: circle_body = pymunk.Body(body_type=pymunk.Body.DYNAMIC)

I tried it like this, and it works: circle_body = pymunk.Body(1, 1666, body_type=pymunk.Body.DYNAMIC)

Ah, this error again. Not the first time it happens: #226 Now I suspect this is the most common mistake..