Allow selfsigned certs #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinteo
reviewed
May 6, 2024
vinteo
reviewed
May 6, 2024
|
Sorry I had it backwards. You are right it should be true. The checkbox
label should reflect that as well.
…On Tue, May 7, 2024, 1:15 PM yeltnar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In custom_components/opensprinkler/const.py
<#286 (comment)>
:
> @@ -12,6 +12,7 @@
DOMAIN = "opensprinkler"
DEFAULT_NAME = "OpenSprinkler"
+DEFAULT_VERIFY_SSL = True
Are you thinking the default state should be allowing non trusted
certificates? Just double checking.
—
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGID7ZYEW4QQDGA7IPRSP3ZBBBN7AVCNFSM6AAAAABHJM3KJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBRHE4DMNRWGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I updated the English strings to be a little more telling. What do you think? |
|
Looks good, if you could please fix the minor linting stuff, thanks |
yeltnar
force-pushed
the
allow-selfsigned-certs
branch
from
1b11695 to
a453d7f
Compare
|
vinteo
approved these changes
May 8, 2024
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow the form that creates the integration with the OpenSprinkler device to have a check box that will disable TLS (SSL) certificate checking so self signed certs can be used.