fix: allow run_seconds to use int or str as keys #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue #284, which pointed out that one of the formats for creating template switches used in the examples no longer works.
Consider this snippet:
If this is called as part of
opensprinkler.run
fromDeveloper tools > Services
, the keys are converted to strings, which is what the code expects. However, if it is part of a template switch, they arrive as integers, whichdict.get()
interprets as a lookup failure and returnsNone
. Ultimately, the run durations are set to 0.This PR attempts to find both int and str keys. If you know of a better way to cover both cases than to use the
default
parameter ofdict.get()
, please speak up.