Enable WebRTC connections to be made to the Domain, i.e., add Web client support. #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebRTC Signaling Channel
Conditionally include WebRTCSignalingServer.h
…annel # Conflicts: # domain-server/src/DomainServer.h
Update WebRTC Windows package
Update webapp feature branch with current master
Update WebRTC for Linux.
WebRTC revisions and updates including the addition of secure connections.
Fix SSL WebSocket Domain server crash.
ctrlaltdavid
added
enhancement
digisomni
changed the title
|
The following links are available: build (macOS-10.15, client) build (ubuntu-18.04, full)
build (windows-latest, full) |
digisomni
approved these changes
Nov 24, 2021
|
I tested it with Kalila on Linux server and both native and web clients, and everything, including chat and messages works perfectly. |
|
Windows server functionality is also tested now and works correcly except for slightly choppy audio from web client. |
digisomni
added
QA Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables browser clients using the Web SDK to connect to the domain server and assignment clients via WebRTC.
WebRTC connections can be enabled/disabled in the server settings. An SSL certificate is required if running a public domain - the Web client needs to be served via HTTPS in order for Web audio to work, which means that the WebSocket used to establish the WebRTC connection with the domain server also needs to be SSL. (If running on localhost or local network, the Web client can be served via HTTP and Web audio will still work, and no SSL cert is required.)