Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript bindings question #1364

Closed
Jamie5 opened this issue Feb 23, 2021 · 5 comments
Closed

Typescript bindings question #1364

Jamie5 opened this issue Feb 23, 2021 · 5 comments

Comments

@Jamie5
Copy link
Contributor

Jamie5 commented Feb 23, 2021

For MapEvent, is it possible for point: Array<number>, to instead be e.g. point: [x: number, y: number] and similarly for lngLat to be [longitude: Lng, latitude: Lat] since we know they both just have two elements, or are there reasons against this?

EDIT: Also, should MjolnirEvent also have leftButton and middleButton?

@Pessimistress
Copy link
Collaborator

are there reasons against this?

No. Would you open a PR to update the typings?

@Jamie5
Copy link
Contributor Author

Jamie5 commented Feb 24, 2021

Do I just do it against master and then that will suffice for both 6.x and 5.x? (we still need 5.x)

@Pessimistress
Copy link
Collaborator

Yes, this should apply to both 6.x and 5.x.

@Jamie5
Copy link
Contributor Author

Jamie5 commented Feb 24, 2021

Created #1369. It does a bit more than mentioned above, though I believe the additional changes are correct.

@VictorVelarde
Copy link
Collaborator

This has been included in the latest patches (6.1.10 and 5.3.10). Thx for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants