Improve typescript bindings #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jamie5
commented
Feb 24, 2021
Jamie5
commented
- Make MapEvent.point/lngLat 2-arrays
- From MjolnirEvent remove deltaX/deltaY/scale/rotation/metaKey which seem like they might not exist, or at least are not in the public API documentation
- From MjolnirEvent make delta/pointerType/rightButton optional, as the API documentation states they are only present for some events
- From MjolnirEvent add stopImmediatePropagation/leftButton/middleButton/key which are supposed to exist per docs
- From MjolnirEvent make typings for stopPropagation/preventDefault/srcEvent more specific
| rightButton: boolean, | ||
| stopPropagation: Function, | ||
| preventDefault: Function, | ||
| delta?: number, |
There was a problem hiding this comment.
Why are some of the fields deleted? They are accessed in map-controller.js:
- deltaX
- deltaY
- scale
- rotation
There was a problem hiding this comment.
Hmm they aren't documented as existing so I wasn't sure if they existed, but given we use them then they certainly do exist. So restored them (but made them optional, because they only exist for some events)
- Make MapEvent.point/lngLat 2-arrays - From MjolnirEvent make deltaX/deltaY/scale/rotation/metaKey optional, as they are undocumented and don't exist for all events - From MjolnirEvent make delta/pointerType/rightButton optional, as the API documentation states they are only present for some events - From MjolnirEvent add stopImmediatePropagation/leftButton/middleButton/key which are supposed to exist per docs - From MjolnirEvent make typings for stopPropagation/preventDefault/srcEvent more specific
VictorVelarde
pushed a commit
that referenced
this pull request
Feb 26, 2021
VictorVelarde
pushed a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.