-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coverage): exclude *.test-d.*
by default
#5634
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As test case let's add should-be-excluded-from-report.test-d.ts
to test/coverage-test/src/
. Simply adding that file should be enough as coverage tests are already validating all files inside that directory. If the new exclusion pattern is removed, some snapshot tests should fail.
{test,spec}-d
by default
Hey @AriPerkkio , |
{test,spec}-d
by default*.test-d.*
by default
Description
Solves issue #5630 5630
Exclude {test,spec}-d files from coverage by default
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.