Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Rerank API (Jina- and Cohere-compatible API) #12376
[Frontend] Rerank API (Jina- and Cohere-compatible API) #12376
Changes from 9 commits
b6610fb
a82b4bb
99acff6
31b5137
485e328
8922f81
dc0d158
4ed459b
676eea0
b66bcc2
c44dee4
cce2873
a38060f
901021f
4849575
36e85a5
4adb94b
dc92240
330aa22
ce85821
29a0366
844d39a
af83c25
a53b59c
17441f5
974c0be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove these warnings as the Cohere Python client will access this URL by default. Unless there's a way to change the URL in the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a way to change the base URL, but that's just the server or hostname. unlike OpenAI which expects you to include the
/v1
in thebase_url
if you change it, cohere doesn't want you to set it, it just wants the host and automatically sets/v1
or/v2
depending on if you use the v1 client or v2 client.I will remove the logger warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to remove or switch to warning_once