Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Make the deviceprofiler include LoRA memory. #14469

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

jeejeelee
Copy link
Collaborator

FIX #14450

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from DarkLight1337 March 8, 2025 03:02
Copy link

github-actions bot commented Mar 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 8, 2025 05:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 8, 2025
@DarkLight1337 DarkLight1337 merged commit b8b0ccb into vllm-project:main Mar 8, 2025
51 checks passed
@jeejeelee jeejeelee deleted the fix-lora-profile branch March 8, 2025 12:32
sethkimmel3 pushed a commit to sethkimmel3/vllm that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance]: LoRA is not taken into account when determining the number of KV cache blocks
2 participants