Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Pythonic tool names flexibility (#14470) #14474

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bjj
Copy link

@bjj bjj commented Mar 8, 2025

This change remaps the tool names to func0..funcN during the parsing step so that pythonic tools only have to match a given regex rather than being strictly valid python. After parsing, the names are mapped back for the API return. This is useful because the OpenAI API is just JSON, and tool names are not really restricted to purely valid python function names.

The regex is then updated to accept leading underscores and kebab-case (the particular example that was plaguing me was n8n's wikipedia-api). Tests are added accordingly, and all pass.

FIX #14470

Copy link

github-actions bot commented Mar 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Mar 8, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin March 8, 2025 12:38
Signed-off-by: Ben Jackson <[email protected]>
@bjj
Copy link
Author

bjj commented Mar 8, 2025

@mdepinet You might be the right person to comment on whether this is desirable, and if so if this is an acceptable approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: pythonic tool parser only accepts alphabetical tool names
1 participant