Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RLHF document #14482

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Add RLHF document #14482

merged 3 commits into from
Mar 8, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 8, 2025

Adds a documentation on RLHF which we can then add more to later.

Signed-off-by: Harry Mellor <[email protected]>
Copy link

github-actions bot commented Mar 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 8, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather refer to openrlhf or verl. these are not complete examples, but just show some basic usage of how to enable rlhf.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've added references to TRL, OpenRLHF and verl. I've also qualified the examples saying that they are basic and should be used as inspiration if you don't want to use the previously mentioned libraries.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 8, 2025 09:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 8, 2025
@DarkLight1337 DarkLight1337 merged commit cfd0ae8 into vllm-project:main Mar 8, 2025
19 of 21 checks passed
@hmellor hmellor deleted the add-rlhf-doc branch March 8, 2025 09:53
sethkimmel3 pushed a commit to sethkimmel3/vllm that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants