Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #4065

Open
feyounger opened this issue Mar 7, 2025 · 1 comment
Open

Refactor code #4065

feyounger opened this issue Mar 7, 2025 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@feyounger
Copy link
Contributor

What is the problem you're trying to solve

The code here can be optimized

	if !found {
		return false
	}

	if jobInfo.Job == nil {
		return false
	}

Describe the solution you'd like

i think is

	if !found || jobInfo.Job == nil {
		return false
	}

Additional context

No response

@feyounger feyounger added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 7, 2025
@feyounger
Copy link
Contributor Author

/assign

feyounger added a commit to feyounger/volcano that referenced this issue Mar 7, 2025
The two judgments can be merged

Fixes volcano-sh#4065
feyounger added a commit to feyounger/volcano that referenced this issue Mar 7, 2025
The two judgments can be merged

Fixes volcano-sh#4065
feyounger added a commit to feyounger/volcano that referenced this issue Mar 7, 2025
The two judgments can be merged

Fixes volcano-sh#4065

Signed-off-by: feyounger <[email protected]>
feyounger added a commit to feyounger/volcano that referenced this issue Mar 7, 2025
The two judgments can be merged

Fixes volcano-sh#4065

Signed-off-by: feyounger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant