fix custom plugin doc and build script #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
kind/bug
volcano-sh-bot
added
kind/documentation
Monokaix
force-pushed
the
custom-plugin
branch
5 times, most recently
from
fde82a7 to
a478e41
Compare
hwdef
reviewed
Feb 26, 2025
hwdef
reviewed
Mar 7, 2025
example/custom-plugin/Dockerfile
Outdated
| apt-get install -y sudo | ||
|
|
||
| RUN wget http://musl.libc.org/releases/musl-1.2.1.tar.gz && \ |
There was a problem hiding this comment.
Suggested change
| RUN wget http://musl.libc.org/releases/musl-1.2.1.tar.gz && \ | |
| RUN wget http://musl.libc.org/releases/musl-latest.tar.gz && \ |
Signed-off-by: Monokaix <[email protected]>
|
/approve |
volcano-sh-bot
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind documentation
/area scheduling
/area deploy
What this PR does / why we need it:
When build custom plugin, we should also re-build base image with CGO enable and
musl-gcc.Which issue(s) this PR fixes:
Fixes #3959
Special notes for your reviewer:
Does this PR introduce a user-facing change?