Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T011/12: Remove pinned jsonschema from env #297

Merged
merged 6 commits into from
Dec 27, 2022
Merged

T011/12: Remove pinned jsonschema from env #297

merged 6 commits into from
Dec 27, 2022

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Dec 27, 2022 •
edited
Loading

Description

Check if we can unpin jsonschema since this issue should be fixed: Yelp/bravado#478

Should fix: #152

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Remove jsonschema pin from env
  • Test CI only for notebooks using bravado
  • Test CI for all

Status

  • Ready to go

@dominiquesydow dominiquesydow self-assigned this Dec 27, 2022
@dominiquesydow dominiquesydow added the dependency Update/fix dependencies label Dec 27, 2022
@dominiquesydow dominiquesydow linked an issue Dec 27, 2022 that may be closed by this pull request
Reminder: Remove jsonschema from environments #152
Closed
@dominiquesydow dominiquesydow changed the title Unpin jsonschema Remove pinned jsonschema from env Dec 27, 2022
@dominiquesydow dominiquesydow mentioned this pull request Dec 27, 2022
Merged
16 tasks
@dominiquesydow dominiquesydow changed the title Remove pinned jsonschema from env T011/12: Remove pinned jsonschema from env Dec 27, 2022
@dominiquesydow dominiquesydow changed the base branch from master to base-ci-env-fix December 27, 2022 15:43
@dominiquesydow dominiquesydow merged commit 075132c into base-ci-env-fix Dec 27, 2022
@dominiquesydow dominiquesydow deleted the unpin-jsonschema branch December 27, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dominiquesydow dominiquesydow

Labels
dependency Update/fix dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsonschema 4.0.0 removes compat module Reminder: Remove jsonschema from environments
1 participant
@dominiquesydow