dhcp::failover parameter scope fix #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btravouillon
approved these changes
Nov 9, 2017
ekohl
approved these changes
Nov 9, 2017
manifests/failover.pp
Outdated
| @@ -12,7 +12,7 @@ | |||
| $load_balance = '3', | |||
| $omapi_key = '', | |||
| $dhcp_dir = $dhcp::params::dhcp_dir, | |||
There was a problem hiding this comment.
Would you mind fixing this as well?
btravouillon
reviewed
Nov 9, 2017
manifests/failover.pp
Outdated
| $dhcp_dir = $dhcp::params::dhcp_dir, | ||
| $dhcpd_conf_filename = $dhcp::params::dhcpd_conf_filename, | ||
| $dhcp_dir = $dhcp::dhcp_dir, | ||
| $dhcpd_conf_filename = $dhcp::dhcpd_conf_filename, | ||
| ) inherits dhcp::params { |
There was a problem hiding this comment.
I believe you can remove the inheritance.
ekohl
approved these changes
Nov 10, 2017
cegeka-jenkins
pushed a commit
to cegeka/puppet-dhcp
that referenced
this pull request
Jun 26, 2020
Remove inheritance of dhcp::params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.