feat: create review and ratings section structure #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
artursantiago
requested review from
eduardoformiga and
lucasfp13
and removed request for
a team
Guilera
force-pushed
the
feat/create-reviews-section
branch
from
03a27d7 to
6c6f756
Compare
Merged
Guilera
force-pushed
the
feat/reviews-and-ratings
branch
from
d57303d to
2203c7f
Compare
Guilera
force-pushed
the
feat/create-reviews-section
branch
from
6c6f756 to
02ccaa7
Compare
hellofanny
reviewed
Feb 14, 2025
| @@ -0,0 +1,6 @@ | |||
| export const ReviewsAndRatingsDefaultComponents = { | |||
| // TODO: Update this with the components that will be used in ReviewsAndRatings section | |||
hellofanny
reviewed
Feb 14, 2025
| @@ -0,0 +1 @@ | |||
| export { default } from './ReviewsAndRatings' | |||
There was a problem hiding this comment.
todo: Rename this file to index.ts
hellofanny
reviewed
Feb 14, 2025
| @@ -0,0 +1,6 @@ | |||
| @layer components { | |||
| .section { | |||
There was a problem hiding this comment.
🎗️
Revisit this after styles are added and components are imported correctly.
hellofanny
approved these changes
Feb 14, 2025
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
## What's the purpose of this pull request? Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview. ## How it works? - **Directory Creation**: A new directory has been created at `packages/core/src/components/sections/ReviewAndRatings`, following the Overridable section structure. - **Support Files**: Files have been added to `packages/core/src/components/plugins/overrides` and `packages/core/src/components/customizations/src/components` to support overrides. - **Product Page Integration**: The section has been integrated into the product page rendering component located at `packages/core/src/pages/[slug]/p.tsx`. - **CMS Configuration**: An entry for the Review and Ratings section has been added to the CMS JSON file at `packages/core/cms/faststore/sections.json`. Currently, only a `title` property is included; additional properties will be incorporated as new components are developed. <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title `Reviews`. If the title doesn't appear you can run `yarn cms-sync` in the `start.store` [branch](vtex-sites/starter.store#686) <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview [Preview](https://starter-git-feat-preview-review-ratings-section-vtex.vercel.app/) <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References [Jira Task: SFS-2084](https://vtex-dev.atlassian.net/browse/SFS-2084)
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
## What's the purpose of this pull request? Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview. ## How it works? - **Directory Creation**: A new directory has been created at `packages/core/src/components/sections/ReviewAndRatings`, following the Overridable section structure. - **Support Files**: Files have been added to `packages/core/src/components/plugins/overrides` and `packages/core/src/components/customizations/src/components` to support overrides. - **Product Page Integration**: The section has been integrated into the product page rendering component located at `packages/core/src/pages/[slug]/p.tsx`. - **CMS Configuration**: An entry for the Review and Ratings section has been added to the CMS JSON file at `packages/core/cms/faststore/sections.json`. Currently, only a `title` property is included; additional properties will be incorporated as new components are developed. <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title `Reviews`. If the title doesn't appear you can run `yarn cms-sync` in the `start.store` [branch](vtex-sites/starter.store#686) <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview [Preview](https://starter-git-feat-preview-review-ratings-section-vtex.vercel.app/) <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References [Jira Task: SFS-2084](https://vtex-dev.atlassian.net/browse/SFS-2084)
Guilera
pushed a commit
that referenced
this pull request
Feb 18, 2025
## What's the purpose of this pull request? Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview. ## How it works? - **Directory Creation**: A new directory has been created at `packages/core/src/components/sections/ReviewAndRatings`, following the Overridable section structure. - **Support Files**: Files have been added to `packages/core/src/components/plugins/overrides` and `packages/core/src/components/customizations/src/components` to support overrides. - **Product Page Integration**: The section has been integrated into the product page rendering component located at `packages/core/src/pages/[slug]/p.tsx`. - **CMS Configuration**: An entry for the Review and Ratings section has been added to the CMS JSON file at `packages/core/cms/faststore/sections.json`. Currently, only a `title` property is included; additional properties will be incorporated as new components are developed. <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title `Reviews`. If the title doesn't appear you can run `yarn cms-sync` in the `start.store` [branch](vtex-sites/starter.store#686) <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview [Preview](https://starter-git-feat-preview-review-ratings-section-vtex.vercel.app/) <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References [Jira Task: SFS-2084](https://vtex-dev.atlassian.net/browse/SFS-2084)
artursantiago
added a commit
that referenced
this pull request
Feb 18, 2025
## What's the purpose of this pull request? Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview. ## How it works? - **Directory Creation**: A new directory has been created at `packages/core/src/components/sections/ReviewAndRatings`, following the Overridable section structure. - **Support Files**: Files have been added to `packages/core/src/components/plugins/overrides` and `packages/core/src/components/customizations/src/components` to support overrides. - **Product Page Integration**: The section has been integrated into the product page rendering component located at `packages/core/src/pages/[slug]/p.tsx`. - **CMS Configuration**: An entry for the Review and Ratings section has been added to the CMS JSON file at `packages/core/cms/faststore/sections.json`. Currently, only a `title` property is included; additional properties will be incorporated as new components are developed. <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title `Reviews`. If the title doesn't appear you can run `yarn cms-sync` in the `start.store` [branch](vtex-sites/starter.store#686) <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview [Preview](https://starter-git-feat-preview-review-ratings-section-vtex.vercel.app/) <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References [Jira Task: SFS-2084](https://vtex-dev.atlassian.net/browse/SFS-2084)
Guilera
pushed a commit
that referenced
this pull request
Feb 19, 2025
## What's the purpose of this pull request? Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview. ## How it works? - **Directory Creation**: A new directory has been created at `packages/core/src/components/sections/ReviewAndRatings`, following the Overridable section structure. - **Support Files**: Files have been added to `packages/core/src/components/plugins/overrides` and `packages/core/src/components/customizations/src/components` to support overrides. - **Product Page Integration**: The section has been integrated into the product page rendering component located at `packages/core/src/pages/[slug]/p.tsx`. - **CMS Configuration**: An entry for the Review and Ratings section has been added to the CMS JSON file at `packages/core/cms/faststore/sections.json`. Currently, only a `title` property is included; additional properties will be incorporated as new components are developed. <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title `Reviews`. If the title doesn't appear you can run `yarn cms-sync` in the `start.store` [branch](vtex-sites/starter.store#686) <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview [Preview](https://starter-git-feat-preview-review-ratings-section-vtex.vercel.app/) <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References [Jira Task: SFS-2084](https://vtex-dev.atlassian.net/browse/SFS-2084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Establish the initial structure for the Review & Ratings section, enabling new components to branch from this foundation, thereby facilitating their testing and preview.
How it works?
Directory Creation: A new directory has been created at
packages/core/src/components/sections/ReviewAndRatings, following the Overridable section structure.Support Files: Files have been added to
packages/core/src/components/plugins/overridesandpackages/core/src/components/customizations/src/componentsto support overrides.Product Page Integration: The section has been integrated into the product page rendering component located at
packages/core/src/pages/[slug]/p.tsx.CMS Configuration: An entry for the Review and Ratings section has been added to the CMS JSON file at
packages/core/cms/faststore/sections.json. Currently, only atitleproperty is included; additional properties will be incorporated as new components are developed.How to test it
You can access the preview link and open any pdp. It already should be able to show the reviews sections with the title
Reviews.If the title doesn't appear you can run
yarn cms-syncin thestart.storebranchStarters Deploy Preview
Preview
References
Jira Task: SFS-2084