-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressor fixes and improvements #72
Conversation
Make it a tool package. It's used on compile time only and will not add dll references to a project itself. Add RequireJsNet.Compressor.targets which is automatically included into a project when package is installed. Put nuspec alongside the project so nuget finds and uses it automatically.
This prevents them from being added to the nuget package dependencies.
CC #71 This pull-request will make Compressor independent of projects dlls versions as package carries its own dlls. |
This crashes the TeamCity NuGet publish job:
|
Looks like project name should match nuspec name |
@@ -7,7 +7,7 @@ | |||
<RestorePackages Condition=" '$(RestorePackages)' == '' ">false</RestorePackages> | |||
|
|||
<!-- Property that enables building a package from a project --> | |||
<BuildPackage Condition=" '$(BuildPackage)' == '' ">false</BuildPackage> | |||
<BuildPackage Condition=" '$(BuildPackage)' == '' ">true</BuildPackage> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to run nuget manually and it doesn't like .csproj
with .teamcity
extension.
I enabled nuget build here. So it probably should be disabled for teamcity.
You can see my TeamCity config using guest account here http://tcoss.veritech.io/project.html?projectId=RequireJSNet |
I'm updating to latest VS.NET on the build server so I can switch to 2015 build tools, restarting server now. Create tool package doesn't fix the build. |
Switching to MS Build 2015 didn't fixed the build. |
I've also update the TeamCity NuGet to 3.4.3 but still crashes... |
Both packages are on NuGet. Thank you very much! |
New package structure:
RequireJsNet.Compressor.targets
automatically included into the project.dll
s are added to the project itself.In simple case user only has to install the package and create

ReqiureJS.json
and bundles will compile. If other config files are needed they can be added by settingBuildAction
toRequireJsNetConfig
:Inspired by RazorGenerator.MsBuild and LessMsbuildTasks