Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack.test.conf.js is not needed in jest and e2e #1135

Merged
merged 1 commit into from
Dec 4, 2017
Merged

webpack.test.conf.js is not needed in jest and e2e #1135

merged 1 commit into from
Dec 4, 2017

Conversation

pwang2
Copy link
Contributor

@pwang2 pwang2 commented Dec 3, 2017

As titled.

@pwang2 pwang2 changed the title webpack.conf.js is not needed in jest and e2e webpack.test.conf.js is not needed in jest and e2e Dec 3, 2017
@LinusBorg
Copy link
Contributor

That's correct, good catch, thanks.

@LinusBorg LinusBorg merged commit 62e45aa into vuejs-templates:develop Dec 4, 2017
LinusBorg added a commit that referenced this pull request Dec 11, 2017
@LinusBorg
Automatically install Dependencies and fix lint errors (#1133)
ecd68c4 
* Batman!

* removed special airbnb template strings since we can auto-fix them now.

* fix string bug

* remove last airbnb template string

* * Make autoinstall optional
* run lint-fix for airbnb AND standard
* print message if user has to manually lint-fix

* webpack.conf.js is not needed in jest and e2e (#1135)

* fix filename of `.eslintignore` (#1136)

* Batman!

* removed special airbnb template strings since we can auto-fix them now.

* fix string bug

* remove last airbnb template string

* * Make autoinstall optional
* run lint-fix for airbnb AND standard
* print message if user has to manually lint-fix

* used chalk to color up console logs

* add option for yarn

* change double quotes to single quotes, remove where possible

* generalize log message
LinusBorg added a commit that referenced this pull request Dec 11, 2017
@LinusBorg
Merge branch 'develop'
b2fd0de 
* develop:
  remove unnecessary exceptions
  bump version to 1.2.6
  Add JX support (close #1146)
  Automatically install Dependencies and fix lint errors (#1133)
  Set `allChunks: true` by default (close #1110) (#1149)
  airbnb eslint config compatibility with vuex (#1003)
  Document babel target env configuration (#1144)
  Revert "remove uneccessary target.browsers (#1004)" (#1083)
  fix filename of `.eslintignore` (#1136)
  webpack.conf.js is not needed in jest and e2e (#1135)

# Conflicts:
#	template/test/e2e/custom-assertions/elementCount.js
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@pwang2 @LinusBorg
webpack.conf.js is not needed in jest and e2e (vuejs-templates#1135)
405a71e
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@LinusBorg
Automatically install Dependencies and fix lint errors (vuejs-templat…
6b96830 
…es#1133)

* Batman!

* removed special airbnb template strings since we can auto-fix them now.

* fix string bug

* remove last airbnb template string

* * Make autoinstall optional
* run lint-fix for airbnb AND standard
* print message if user has to manually lint-fix

* webpack.conf.js is not needed in jest and e2e (vuejs-templates#1135)

* fix filename of `.eslintignore` (vuejs-templates#1136)

* Batman!

* removed special airbnb template strings since we can auto-fix them now.

* fix string bug

* remove last airbnb template string

* * Make autoinstall optional
* run lint-fix for airbnb AND standard
* print message if user has to manually lint-fix

* used chalk to color up console logs

* add option for yarn

* change double quotes to single quotes, remove where possible

* generalize log message
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@LinusBorg
Merge branch 'develop'
882693c 
* develop:
  remove unnecessary exceptions
  bump version to 1.2.6
  Add JX support (close vuejs-templates#1146)
  Automatically install Dependencies and fix lint errors (vuejs-templates#1133)
  Set `allChunks: true` by default (close vuejs-templates#1110) (vuejs-templates#1149)
  airbnb eslint config compatibility with vuex (vuejs-templates#1003)
  Document babel target env configuration (vuejs-templates#1144)
  Revert "remove uneccessary target.browsers (vuejs-templates#1004)" (vuejs-templates#1083)
  fix filename of `.eslintignore` (vuejs-templates#1136)
  webpack.conf.js is not needed in jest and e2e (vuejs-templates#1135)

# Conflicts:
#	template/test/e2e/custom-assertions/elementCount.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
PR:ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwang2 @LinusBorg