Handle npm install error gracefully #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this as I think we don't need it after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
See #1168 - it ssems to be fixed by #1170 already, but imrpoving the error handling in case something breaks might still be a good idea.
Thougths?
What does this PR add/change?
When the user has chosen to let the template automatically install dependencies, and that call to
npm installfails, We now display a usefull error message with instructions on how to proceed.Is that a perfect solution?
Not really, but it helps to proceed even if autoInstall fails.
If someone for whom this process fails would be willing to investigate, that would be much apprechiated. Since I can't reproduce the error from #1168, I don't know how to debug this.
To test this PR:
Thanks!