chore: change yorkie to simple-git-hooks #2466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #2464, I noticed that the formatting was incorrect on the imports. I wondered why that hadn't been automatically fixed on commit.
There are several reasons why this isn't working. I didn't want to create a huge PR, so here I've just switched
yorkie
tosimple-git-hooks
. By itself, this wouldn't have prevented the formatting problems seen in #2464, as it isn't checking.mjs
files. Changing that is more complicated than it sounds, so I'll open other PRs to fix the other problems.yorkie
doesn't work with pnpm, the git hooks aren't created. For anyone who cloned the repo before it used pnpm, it might appear as though everything is working fine, but the git hooks aren't created for a fresh clone.Most of the Vue ecosystem has moved away from
yorkie
and is now usingsimple-git-hooks
, including Vue core and Pinia.For reference, vuejs/core#7069 is the PR that migrated Vue core. The changes I've made here are very similar.
Close #2464