Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change yorkie to simple-git-hooks #2466

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

skirtles-code
Copy link
Contributor

@skirtles-code skirtles-code commented Feb 26, 2025

While reviewing #2464, I noticed that the formatting was incorrect on the imports. I wondered why that hadn't been automatically fixed on commit.

There are several reasons why this isn't working. I didn't want to create a huge PR, so here I've just switched yorkie to simple-git-hooks. By itself, this wouldn't have prevented the formatting problems seen in #2464, as it isn't checking .mjs files. Changing that is more complicated than it sounds, so I'll open other PRs to fix the other problems.

yorkie doesn't work with pnpm, the git hooks aren't created. For anyone who cloned the repo before it used pnpm, it might appear as though everything is working fine, but the git hooks aren't created for a fresh clone.

Most of the Vue ecosystem has moved away from yorkie and is now using simple-git-hooks, including Vue core and Pinia.

For reference, vuejs/core#7069 is the PR that migrated Vue core. The changes I've made here are very similar.

Close #2464

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 606d5ed
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/67bf4359285f76000860523d

Copy link

pkg-pr-new bot commented Feb 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vue-router@2466

commit: 606d5ed

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (1ad847e) to head (606d5ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files          34       34           
  Lines        2993     2993           
  Branches      845      845           
=======================================
  Hits         2840     2840           
  Misses        150      150           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is long overdue

@posva posva merged commit b2e0835 into vuejs:main Feb 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants