fix(style): sets max-width 100% for images in .content #382
Conversation
An overly wide hero image will run out of the container and make the otherwise normally sized page on mobile horizontally scroll-able. refs: edm00se/awesome-board-games#5 fixes #381
|
If this is desired more globally, this could easily be moved up to encompass all images, such as hero images. I noticed this on the home page, as it's where I was most likely to put a large image. |
edm00se
changed the title
There was a problem hiding this comment.
Thanks! I think this is an important feature to be included in core. Maybe it is a good idea to include this globally as well. But let's see what @ulivz and @meteorlxy thinks.
|
😁 |
|
Well actually, we have this already at The problem is probably because we have used vuepress/lib/default-theme/Home.vue Line 19 in 7813fa8 Not sure the reason behind this decision. We probably need to wait for @ulivz for advice. 😄 |
|
Curious, as the result wasn't observable in mine earlier today. Is that commit included in the Here's an example of it live, using As an aside, it would be great if the git tags were to be re-introduced, as they seem to be quite a bit behind what's published to npm. |
|
@edm00se |
|
Aha. Well, this ought to take care of it on the other side of things then. |
There was a problem hiding this comment.
This should be added to this instead even if actually needed
https://github.com/vuejs/vuepress/blob/master/lib/default-theme/styles/theme.styl#L70
|
Ah, I see, since it's already split logic. I'll close this PR and work up a new commit for the Thanks @ycmjason. |
An overly wide hero image will run out of the container and make the otherwise normally sized page
on mobile horizontally scroll-able.
refs: edm00se/awesome-board-games#5
fixes #381