Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Enveloped Credentials and Enveloped Presentations #461

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jrhender
Copy link
Contributor

Partially addresses #424 . The objective of the PR is to add support for verifying application/vc and application/vp requests.

Two changes in the PR:

  1. Adjusts respect-oas.js to support request schemas with multiple content-types. The UI change at the moment is that the text before each of the request schema tables is appended with "... with content-type header set to application/json", for example "The /presentations/verify endpoint uses the following schema when receiving a POST with content-type header set to application/json:". I'm open to adjusting this if folks have a different rendering preference.

  2. Adds application/vc and application/vp schemas for POST /credentials/verify and POST /presentations/verify respectively

@msporny
Copy link
Contributor

msporny commented Feb 25, 2025

The group discussed this on the 2025-02-25 call and found that we do not expect application/vc or application/vp to be posted instead of application/json, but do expect oneOf the JSON Schemas listed to be used. The media type for the request will only ever be application/json with different schemas used when VCs or VPs are POSTed.

The PR needs to be updated so that the application/vc or application/vp media types aren't allowed for posting, only application/json and any of the schemas should be possible (based on the call being made).

Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoints will receive application/json always -- any use of application/vc or application/vp are not allowed (even though VCs or VPs posted inside the JSON body are allowed/expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants