Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning editors into contributor section #453

Open
wants to merge 12 commits into
base: gh-pages
Choose a base branch
from

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Feb 10, 2025

As title, along with URL redirect fix.

@kidayasuo @xfq @r12a see middle part (lines 104-147 in new column). Do we have any other item to be mentioned here?

@himorin himorin requested review from xfq, r12a and kidayasuo February 10, 2025 14:56
@himorin
Copy link
Contributor Author

himorin commented Feb 10, 2025

test material at https://jlreq-old.w3c.himor.in/NOTE-jlreq-20250218/Overview.html
pubrules passed.

@kidayasuo
Copy link
Contributor

kidayasuo commented Feb 11, 2025

Three comments:

  1. I believe it would be appropriate to add Bin-sensei as one of the Editors, as the improvements he proposed are reflected in this version. We could consider listing him as the sole Author, but that might be a bit too much since this update is not primarily based on his work.
  2. I feel that listing contributions in reverse chronological order (newest first) is more natural. However, if there is an established practice, we will follow that.
  3. Could you unify the sentence-ending style? The Abstract currently uses the ですます style.

Update: Please also add Nat McCully to the list of Editors. He made editorial contributions to the English version.

Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

@r12a
Copy link
Contributor

r12a commented Feb 11, 2025

Also, the addition of the dates of publication of the previous versions (in the Contributors section) is useful and a good idea. I'll just note that we usually recommend the use of a name for the month (a 3-letter abbreviation is fine) to reduce potential ambiguity — i know that the YMD approach is less ambiguous than other date formats, but it is also less familiar for many readers of English. (Of course, this comment doesn't affect the Japanese translation.)

@r12a
Copy link
Contributor

r12a commented Feb 11, 2025

Should we keep the affiliation information for the contributors?

@himorin
Copy link
Contributor Author

himorin commented Feb 17, 2025

Should we keep the affiliation information for the contributors?

ah, just followed another spec I've working on, but no personal preference,,, e.g. https://www.w3.org/TR/webxr/#ack
seeking others, mostly without affiliation for acknowledgments, removed them.

@himorin himorin requested a review from r12a February 17, 2025 15:31
@r12a
Copy link
Contributor

r12a commented Feb 18, 2025

ah, just followed another spec I've working on, but no personal preference,,, e.g. https://www.w3.org/TR/webxr/#ack seeking others, mostly without affiliation for acknowledgments, removed them.

My feeling is that we should also acknowledge that the organisations involved allowed the individuals to work on this, which is the main reason for keeping the affiliation information.

@himorin
Copy link
Contributor Author

himorin commented Feb 26, 2025

ah, just followed another spec I've working on, but no personal preference,,, e.g. https://www.w3.org/TR/webxr/#ack seeking others, mostly without affiliation for acknowledgments, removed them.

My feeling is that we should also acknowledge that the organisations involved allowed the individuals to work on this, which is the main reason for keeping the affiliation information.

If so, I would rather keep former format with combination of name and affiliation.
With writing separately something like we appreciate contributions of following organizations: xxx, additional meaning than affiliation could be included, and it is quite hard to check history over 20 years. We may ask Binn-sensei about any contribution, of course...

@r12a
Copy link
Contributor

r12a commented Feb 26, 2025

keep former format with combination of name and affiliation

I'm not sure what you mean by that. I was suggesting that we just add the affiliation (the one currently in the document's front matter) after the name in parens. But it's only a suggestion. If you prefer to leave as is, that's ok too.

@himorin
Copy link
Contributor Author

himorin commented Mar 3, 2025

@himorin himorin requested review from r12a, xfq and kidayasuo and removed request for xfq, r12a and kidayasuo March 3, 2025 01:20
@@ -76,16 +59,16 @@
<body>
<h1 class="title p-name" id="title">Requirements for Japanese Text Layout <br/><span lang="ja">日本語組版処理の要件(日本語版)</span></h1>

<div id="abstract">
<section id="abstract">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i remember correctly, we used the div markup here to avoid warning messages about using a section with no heading. You might want to check that out.

Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Thank you!

company: "Invited Expert",
w3cid: "40266" },
{ name: "Nathaniel McCully, (<span lang='ja'>第2版</span> 2nd edition)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include this @kidayasuo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this.
Yes, please add Nat. He contributed to the English translations as an editor.

Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The change looks good.

@himorin
Copy link
Contributor Author

himorin commented Mar 11, 2025

memo from 2025-03-11 JL-TF call, @kidayasuo will contact xfq and Richard about how to organize both editor field and contributors section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants