Fix #1268 Type transport strings as DOMStrings. #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently transports are represented as an enum. However, WebIDL has strict enums. (I.e. an RP which sent an unrecognised transport would make the whole structure unparsable.) This means that every time we add a transport, we break all existing browsers. In order to address this, this change retypes transports as plain DOMStrings. The AuthenticatorTransport enum still exists, but now only as documentation and registry — not as a factor in type-checking.
emlun
requested changes
Aug 14, 2019
jcjones
changed the title
|
This is a fix for #1268. |
equalsJeffH
approved these changes
Aug 20, 2019
emlun
approved these changes
Aug 21, 2019
|
on 21-08-2019 call, this is ready to land modulo re-review & lgtm from @emlun |
akshayku
approved these changes
Aug 28, 2019
WebAuthnBot
pushed a commit
that referenced
this pull request
Aug 28, 2019
emlun
added a commit
to Yubico/java-webauthn-server
that referenced
this pull request
Nov 1, 2019
Changes:
- `RelyingParty` now makes an immutable copy of the `origins` argument,
instead of storing a reference to a possibly mutable value.
- The enum `AuthenticatorTransport` has been replaced by a value class
containing methods and value constants equivalent to the previous
enum.
- The return type of `PublicKeyCredentialDescriptor.getTransports()` is
now a `SortedSet` instead of `Set`. The builder still accepts a plain
`Set`.
- Registration ceremony now verifies that the returned credential public
key matches one of the algorithms specified in
`RelyingParty.preferredPubkeyParams` and can be successfully parsed.
New features:
- Origin matching can now be relaxed via two new `RelyingParty` options:
- `allowOriginPort` (default `false`): Allow any port number in the
origin
- `allowOriginSubdomain` (default `false`): Allow any subdomain of any
origin listed in `RelyingParty.origins`
- See JavaDoc for details and examples.
- The new `AuthenticatorTransport` can now contain any string value as
the transport identifier, as required in the editor's draft of the L2
spec. See: w3c/webauthn#1275
- Added support for RS1 credentials. Registration of RS1 credentials is
not enabled by default, but can be enabled by setting
`RelyingParty.preferredPubKeyCredParams` to a list containing
`PublicKeyCredentialParameters.RS1`.
- New constant `PublicKeyCredentialParameters.RS1`
- New constant `COSEAlgorithmIdentifier.RS1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently transports are represented as an enum. However, WebIDL has
strict enums. (I.e. an RP which sent an unrecognised transport would
make the whole structure unparsable.) This means that every time we add
a transport, we break all existing browsers.
In order to address this, this change retypes transports as plain
DOMStrings. The AuthenticatorTransport enum still exists, but now only
as documentation and registry — not as a factor in type-checking.
fixes #1268
Preview | Diff