Clarify when an element is disabled #1807
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
requested changes
Apr 15, 2024
Selenium's atom "Is Element Enabled" special-cases the disabled state for "option" and "optgroup" elements when the nearest anchestor "select" is disabled as well.
whimboo
force-pushed
the
element-disabled
branch
from
41e5517 to
8f951ba
Compare
|
There is currently a bug in the Actions workflow for |
whimboo
requested review from
gsnedders,
sadym-chromium,
jgraham,
shs96c and
AutomatedTester
AutomatedTester
approved these changes
Apr 16, 2024
|
As per Matrix @jgraham is fine with the rest of the changes. And thanks to @AutomatedTester we got also feedback from the Selenium side. So lets get this PR merged. |
jgraham
approved these changes
Apr 16, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 16, 2024
SHA: 98140ea Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
Apr 16, 2024
SHA: 98140ea Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Apr 17, 2024
SHA: 98140ea Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium's atom "Is Element Enabled" special-cases the disabled state for "option" and "optgroup" elements when the nearest anchestor "select" is disabled as well.
@jgraham please let me know if that is what you would imagine based on your comment from:
https://bugzilla.mozilla.org/show_bug.cgi?id=1863266#c12
Preview | Diff