fix for nats_kv to be consistent in passing meta values along #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
reviewed
Jan 15, 2025
internal/impl/nats/metadata.go
Outdated
Comment on lines
31
to
36
| msg := service.NewMessage(entry.Value()) | ||
| //nolint:errcheck | ||
| src.MetaWalkMut(func(key string, value any) error { | ||
| msg.MetaSetMut(key, value) | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
Would probably be easier to just set the bytes of the original message to the new content. That way we can retain all the original metadata without needing to construct a new message from the KV entry.
Suggested change
| msg := service.NewMessage(entry.Value()) | |
| //nolint:errcheck | |
| src.MetaWalkMut(func(key string, value any) error { | |
| msg.MetaSetMut(key, value) | |
| return nil | |
| }) | |
| msg := src.Copy() | |
| msg.SetBytes(entry.Value()) |
This way would also retain the original message's context -- and therefore its tracing ID.
There was a problem hiding this comment.
I would rather do it in a different way that mimics the workflow of the other operations. Se added commit
gregfurman
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nats_kvprocessor removed all meta values from message on succes. That is not consistent behaviour with other operations.getandget_revisionnow copy any pre existing meta values on success.getandget_revisionas well as one other operation for consistency.