feat: S2 Input and Output plugins

[vrongmeal]

No description provided.

[vrongmeal]

The lint failures don't seem to be related to this change.

[vrongmeal]

There seems to be some issue with the specific golangci-lint version on why the lint timeouts.

[gregfurman]

Awesome contribution! 🚀 Have left some comments. Mostly cosmetic suggestions (feel free to ignore nits) but some (like the use of panic) require some feedback.

Also, is there any chance you can add an integration test? Doesn't need to be complicated but would just provide some sanity checks 🙂 See this NATS test for an example.

Also, I'll look into this weird golangci-lint issue.

[vrongmeal]

Hey @gregfurman. Thank you for your review. I'll address most of your concerns with the PR.

Also, is there any chance you can add an integration test?

I don't think I can do this right-now. We do want to create a mock-server that we can use for testing. Will add an integration test as soon as we have that.

[vrongmeal]

@gregfurman I have updated the PR.

[gregfurman]

Thanks for addressing comments!

Golang lint job seemed to be OOM killed. Looks like an issue with Go v1.23. (from golangci/golangci-lint#4909) and fixed in 1.63.x. Will update the CI to a later version.

Also, can you double check on that s2 dependency requiring 1.23.4?

[gregfurman]

LGTM! Thanks for the fast response time on my feedback @vrongmeal!

I'll look into creating a mock server for this plugin similar to what we do for GCP with http handlers created on-the-fly.

Lemme know if all works fine! Else, reach out on Slack or Discord if you need any help.

BTW, love the product! I recall seeing S2 on HackerNews a couple of months ago and am excited to see where the project goes 🚀 🙂

[vrongmeal]

Thanks for your kind words!

Loved working on Bento plugins. The architecture's super extendable and everything just works so smoothly! Really glad to have S2 plugins merged.

I'll look into creating a mock server for this plugin similar to what we do for GCP with http handlers created on-the-fly.

This is so great! For testing Bento, I think implementing just the StreamService should suffice. There might be some changes required on the SDK side (for eg, HTTPS is enabled by default and cannot be configured). Would love to help out!