Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for shutdown before using fallback output component #234

Merged

Conversation

jem-davies
Copy link
Collaborator

No description provided.

@jem-davies
Copy link
Collaborator Author

#216

@gregfurman gregfurman changed the title check if hard shutdown has started before sending to channels in fall… fix: Check for shutdown before using fallback output component Feb 11, 2025
Copy link
Collaborator

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I changed the title of the PR to better reflect the changes. Nice one!

@jem-davies jem-davies merged commit a7a96dd into main Feb 11, 2025
3 checks passed
@jem-davies jem-davies deleted the fallback-sending-to-closed-channels-during-hard-shutdown branch February 11, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants