Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if orbit pipeline exists in create #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

check if orbit pipeline exists in create #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
875618e
read pipeline resource using type for orbit
arjunnair1997 Mar 4, 2025
77ee2ad
check if orbit pipeline exists in create
arjunnair1997 Mar 4, 2025
d1fd666
fix
arjunnair1997 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/provider/api/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ type HTTPDeletePipelineResponse struct {
type HTTPDescribePipelineRequest struct {
VirtualClusterID string `json:"virtual_cluster_id"`
PipelineID string `json:"pipeline_id"`
PipelineType string `json:"pipeline_type"`
}

type HTTPDescribePipelineResponse struct {
Expand Down
58 changes: 44 additions & 14 deletions internal/provider/pipeline_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,23 +148,52 @@ func (r *pipelineResource) Create(ctx context.Context, req resource.CreateReques
return
}

c, err := r.client.CreatePipeline(ctx, api.HTTPCreatePipelineRequest{
VirtualClusterID: plan.VirtualClusterID.ValueString(),
PipelineName: plan.Name.ValueString(),
Type: plan.Type.ValueString(),
})
if err != nil {
resp.Diagnostics.AddError(
"Pipeline Creation Failed",
fmt.Sprintf("Failed to create pipeline '%s' in virtual cluster '%s': %s", plan.Name.ValueString(), plan.VirtualClusterID.ValueString(), err),
)
return
// There is only a single orbit pipeline. In the case of orbit, check if the pipeline already exists,
// and if it does, use that.
var pipelineID string
if plan.Type.ValueString() == orbitPipelineType {
// Get pipeline by pipeline type instead of id. This is because there can only be one orbit
// pipeline per virtual cluster, and the UI can automatically create this.
pipeline, err := r.client.DescribePipeline(ctx, api.HTTPDescribePipelineRequest{
VirtualClusterID: plan.VirtualClusterID.ValueString(),
PipelineType: orbitPipelineType,
})
if err != nil {
resp.Diagnostics.AddError(
"Pipeline Creation Failed",
fmt.Sprintf(
"Failed to describe orbit pipeline '%s' in virtual cluster '%s': %s",
plan.Name.ValueString(),
plan.VirtualClusterID.ValueString(),
err,
),
)
return
}
pipelineID = pipeline.PipelineOverview.ID
}
plan.ID = types.StringValue(c.PipelineID)

if pipelineID == "" {
c, err := r.client.CreatePipeline(ctx, api.HTTPCreatePipelineRequest{
VirtualClusterID: plan.VirtualClusterID.ValueString(),
PipelineName: plan.Name.ValueString(),
Type: plan.Type.ValueString(),
})
if err != nil {
resp.Diagnostics.AddError(
"Pipeline Creation Failed",
fmt.Sprintf("Failed to create pipeline '%s' in virtual cluster '%s': %s", plan.Name.ValueString(), plan.VirtualClusterID.ValueString(), err),
)
return
}
pipelineID = c.PipelineID
}

plan.ID = types.StringValue(pipelineID)

cc, err := r.client.CreatePipelineConfiguration(ctx, api.HTTPCreatePipelineConfigurationRequest{
VirtualClusterID: plan.VirtualClusterID.ValueString(),
PipelineID: c.PipelineID,
PipelineID: pipelineID,
ConfigurationYAML: plan.ConfigurationYAML.ValueString(),
})
if err != nil {
Expand Down Expand Up @@ -231,6 +260,7 @@ func (r *pipelineResource) Read(ctx context.Context, req resource.ReadRequest, r
VirtualClusterID: state.VirtualClusterID.ValueString(),
PipelineID: state.ID.ValueString(),
})

if err != nil {
if errors.Is(err, api.ErrNotFound) {
resp.State.RemoveResource(ctx)
Expand Down Expand Up @@ -259,7 +289,7 @@ func (r *pipelineResource) Read(ctx context.Context, req resource.ReadRequest, r
}
}

// Set state
// Set state.
diags = resp.State.Set(ctx, &state)
resp.Diagnostics.Append(diags...)
if resp.Diagnostics.HasError() {
Expand Down
Loading