This repository was archived by the owner on Oct 31, 2023. It is now read-only.
feat(*) wadm 0.4 support in wash app
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
#382 is biting me here |
brooksmtownsend
force-pushed
the
feat/wadm_0.4_support
branch
3 times, most recently
from
d976234 to
fdffb0f
Compare
brooksmtownsend
commented
Apr 26, 2023
Comment on lines
-400
to
+460
| let _ = write!(out_text, "\n\n🛑 To stop wasmCloud, run \"wash down\""); | ||
| let _ = write!(out_text, "\n\n⬇️ To stop wasmCloud, run \"wash down\""); |
There was a problem hiding this comment.
@autodidaddict changed after your comment 😄
brooksmtownsend
force-pushed
the
feat/wadm_0.4_support
branch
from
f385660 to
599fefb
Compare
brooksmtownsend
requested review from
autodidaddict and
thomastaylor312
as code owners
brooksmtownsend
force-pushed
the
feat/wadm_0.4_support
branch
from
adb8b22 to
12b4df0
Compare
This was referenced May 2, 2023
connorsmith256
previously approved these changes
May 2, 2023
Signed-off-by: Brooks Townsend <[email protected]> updated app subcommand to use wadm lib Signed-off-by: Brooks Townsend <[email protected]> updated to git dep temporarily Signed-off-by: Brooks Townsend <[email protected]> try the oldest version that compiles Signed-off-by: Brooks Townsend <[email protected]> pinned to wadm 0.4 branch Signed-off-by: Brooks Townsend <[email protected]> removed extraneous println Signed-off-by: Brooks Townsend <[email protected]> pinned to tag Signed-off-by: Brooks Townsend <[email protected]> bumped to wash lib 0.8.0 Signed-off-by: Brooks Townsend <[email protected]> pull back a few versions, ensure rustls Signed-off-by: Brooks Townsend <[email protected]> WIP starting wadm in wash up Signed-off-by: Brooks Townsend <[email protected]> wip Signed-off-by: Brooks Townsend <[email protected]> attempted to fix OCI issue Signed-off-by: Brooks Townsend <[email protected]> reverted version experiments Signed-off-by: Brooks Townsend <[email protected]> fixed imports for windows Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> use sync_all from docs instead of flush Signed-off-by: Brooks Townsend <[email protected]> removed println breaking json tests lolsob Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> initial wadm up support, detach wip Signed-off-by: Brooks Townsend <[email protected]> attempt to give erlang some grace Signed-off-by: Brooks Townsend <[email protected]> initial pidfile support for stopping wadm Signed-off-by: Brooks Townsend <[email protected]> cleaned up minus a few TODOs for review Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> removed force flag for now Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/wadm_0.4_support
branch
from
915240f to
ab6f892
Compare
Signed-off-by: Brooks Townsend <[email protected]>
connorsmith256
previously approved these changes
May 2, 2023
ricochet
reviewed
May 2, 2023
ricochet
previously approved these changes
May 3, 2023
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
dismissed stale reviews from ricochet and connorsmith256
via
c08064f
connorsmith256
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
After the many changes going into
wadm0.4, there were a few changes to the app subcommand in order to make it compatible with the new types. Additionally, this PR adds inwadmas a binary to download as a part of runningupso that we can immediately interact withwadm.You should consider reviewing this PR as two big sections: the
wash upwadm support, and the changes to theappmodule.This PR
wadmas another binary that can be downloaded + started withwash upappsubcommand to match the Wadm NATS APIcargo update#382Related Issues
(pr) wasmCloud/wadm#89
Fixes #382
Release Information
v0.18.0
Consumer Impact
Consumers of the Elixir implementation of wadm will see breaking changes here, as expected, so with the v0.18.0 release notes we should note that the latest version of wadm should be used.
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
Manual tested with wasmCloud/wadm#89