This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Add wash build docs
#529
Merged
Add wash build docs
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-rash
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
|
I deciphered the code as well as I could.....it'd be good if @mattwilkinsonn could sanity check it all |
Signed-off-by: jordan-rash <[email protected]>
jordan-rash
force-pushed
the
docs/wash_build
branch
from
48e1595 to
d501fe9
Compare
brooksmtownsend
previously approved these changes
Apr 26, 2023
There was a problem hiding this comment.
This is awesome @jordan-rash ! I'm starting to wonder if we need to start breaking up this README, or otherwise putting this content on wasmcloud.com too, but this is great for now. Left a nit, and @mattwilkinsonn can feel free to drop a review too
Update.....later this week 😅 |
|
I will drop a review today! Thank you for writing these @jordan-rash! |
|
@jordan-rash would you mind addressing the two nits? Then I can merge this in 😄 |
Signed-off-by: jordan-rash <[email protected]>
brooksmtownsend
approved these changes
May 8, 2023
brooksmtownsend
approved these changes
May 8, 2023
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Adds documentation for
wash build