This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fix wash-lib CI by running it on PR, fix wadm test #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
requested review from
autodidaddict and
thomastaylor312
as code owners
brooksmtownsend
changed the title
connorsmith256
previously approved these changes
May 11, 2023
brooksmtownsend
force-pushed
the
fix/wash-lib-ci
branch
from
3a4f25f to
ce88a17
Compare
Signed-off-by: Brooks Townsend <[email protected]> see why fail Signed-off-by: Brooks Townsend <[email protected]> who made different operating systems anyways Signed-off-by: Brooks Townsend <[email protected]> actually handled different OS errors Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
fix/wash-lib-ci
branch
from
ce88a17 to
45615d9
Compare
| let config = WadmConfig { | ||
| structured_logging: false, | ||
| js_domain: None, | ||
| nats_server_url: "nats://127.0.0.1:54321".to_string(), |
There was a problem hiding this comment.
That's the same port number I have on my luggage!
autodidaddict
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR ensures we run wash-lib CI on PR so we don't get surprised when we try to release, https://github.com/wasmCloud/wash/actions/runs/4949296556, and fixes a wadm test that ended up connecting to the NATS server running in parallel on accident.
Related Issues
N/A
Release Information
N/A
Consumer Impact
None
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
Tests work for me now