Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

feat(ux): flatten wash reg push/pull into wash push/pull #580

Merged
merged 1 commit into from
May 31, 2023
Merged

feat(ux): flatten wash reg push/pull into wash push/pull #580

merged 1 commit into from
May 31, 2023

Conversation

vados-cosmonic
Copy link
Contributor

Feature or Problem

Flatten wash reg push into wash push
Flatten wash reg pull into wash pull

See:

Related Issues

Release Information

next

Consumer Impact

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Altered the existing integration tests to use the new subcommands

Manual Verification

@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented May 31, 2023

Weird issue with clap -- getting messages saying the crate is undeclared after moving the Registry...Commands into wash-lib.

[EDIT] Looks like this has to do with making clap optional -- should be able to change the test script

Copy link
Contributor

@connorsmith256 connorsmith256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connorsmith256 connorsmith256 merged commit a553348 into wasmCloud:main May 31, 2023
@vados-cosmonic vados-cosmonic deleted the feat/ux/wash-reg-push-and-pull branch May 31, 2023 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants