Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

fix: downgrade wit-parser #897

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: downgrade wit-parser #897

merged 1 commit into from
Oct 16, 2023

Conversation

ricochet
Copy link
Contributor

Without this change, cargo install may fail.

wit-component 0.14.6 has been yanked. This is the version I had.

There isn't a combination of the latest released
versions that works without pulling conflicting versions
of wit-parser. That's why we go back a version of wit-parser.

Signed-off-by: Bailey Hayes [email protected]

Without this change, `cargo install` may fail.

wit-component 0.14.6 has been yanked. This is the version I had.

There isn't a combination of the latest released
versions that works without pulling conflicting versions
of wit-parser. That's why we go back a version of wit-parser.

Signed-off-by: Bailey Hayes <[email protected]>
@ricochet
Copy link
Contributor Author

Fallout from bytecodealliance/wasm-tools#1250

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, if you'd like we can go ahead and add a patch to this for wash-lib and wash-cli so we can yank the non-compiling version

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with a cargo install

Copy link
Contributor

@connorsmith256 connorsmith256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested e2e by building a tinygo component from this branch and ensuring it could instantiate with version v0.79.0 of the host 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants