Update OmegaConf and remove PyTorch from dependencies #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having PyTorch in the dependencies only causes problems. You won't get the right version anyway with poetry and just the presence of PyTorch in the dependencies slows down `poetry update` enormously. It's just not worth it.
|
I'm a bit surprised that all the |
|
torch is still installed in the CI. I'm just doing it manually so that we get the CPU version: |
|
Hm, though I should maybe pin the pytorch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having PyTorch in the dependencies only causes problems. You won't get the right version anyway with poetry and just the presence of PyTorch in the dependencies slows down
poetry updateenormously. It's just not worth it.