Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When constructing a datatuple check for overlapping columns #692

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

tmke8
Copy link
Member

@tmke8 tmke8 commented Jun 22, 2022

No description provided.

@tmke8 tmke8 added the code-change An actual code change. label Jun 22, 2022
@tmke8
Copy link
Member Author

tmke8 commented Jun 22, 2022

Okay, I reworked the solution. Overlap between s and x is allowed now but only if the columns are actually identical. overlap between y and x is still not allowed (because that feels like a bug).

@tmke8 tmke8 requested a review from olliethomas June 22, 2022 15:36
@tmke8 tmke8 merged commit 830a4a9 into main Jun 22, 2022
@tmke8 tmke8 deleted the overlapping-columns branch June 22, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-change An actual code change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant