Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generative/reranker config UX #249

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Jan 10, 2025

  • Allow updating of generative and reranker configs dynamically
  • Fix typing issues with generative and reranker configs

Closes #222

- Allow updating of generative and reranker configs dynamically
- Fix typing issues with generative and reranker configs
@tsmith023 tsmith023 requested a review from a team as a code owner January 10, 2025 13:13
@tsmith023 tsmith023 changed the title Improve generative/reranker UX Improve generative/reranker config UX Jan 10, 2025
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 2   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
🛡️ The following SAST misconfigurations have been detected
NAME FILE
medium Detects Potential Object Injection via User Input ...ns/config/classes.ts View in code
medium Detects Potential Object Injection via User Input ...ns/config/classes.ts View in code

@bevzzz
Copy link

bevzzz commented Jan 11, 2025

Small nitpick in the tests, LGTM besides that

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit 3164cfd into main Jan 13, 2025
13 checks passed
@tsmith023 tsmith023 deleted the #222/support-updating-generative-and-reranker branch January 13, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for updating generative and reranker moduleconfig
3 participants