-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: diagnosable modules #4924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Dec 6, 2023
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
c438b64
to
8bee308
Compare
0143b8b
to
0e70ef1
Compare
8bee308
to
4f6bdb0
Compare
0e70ef1
to
a5b1bed
Compare
4f6bdb0
to
106514c
Compare
a5b1bed
to
c046417
Compare
106514c
to
3bacb8c
Compare
c046417
to
0894cfe
Compare
3bacb8c
to
4eafe62
Compare
0894cfe
to
b50e77a
Compare
dc282b0
to
23c5ddb
Compare
0bb3bf9
to
62886d7
Compare
23c5ddb
to
4afbd9a
Compare
7109327
to
c55a30c
Compare
f58828a
to
3fdf86d
Compare
Test Compatibility Diff
Unpassed tests
|
3fdf86d
to
8e982fd
Compare
ahabhgk
approved these changes
Dec 18, 2023
#3103, this is a good start for removing |
This was referenced Dec 19, 2023
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
* feat: diagnosable modules * save * improve * improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Rspack's module error with Webpack's.
Added trait
Diagnosable
for diagnostics.See how webpack did this
Test Plan
Require Documentation?