-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minify option to lightningcss-loader #7653
feat: add minify option to lightningcss-loader #7653
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍🏻
This option is useful when using style-loader
, as the built-in LightningCssMinimizerRspackPlugin
can not handle CSS files injected by style-loader
, and users can use this option to minify CSS.
Summary
When we use buildin:lightningcss,The production code can only be compressed from the rule,Code space cannot be compressed, such as cssnano's normalizewhitespace feature
for the following reason
The first argument to the
stylesheet.to_css
method is a fixed false,So,When we use rspack or rebuild, do we use
lightningcss
compression capabilities to the user,At the same time, rsbuild can increase the scalability when built-in that
rsbuild issure#3247
Checklist