Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(infra): improve e2e test stability #7713

Merged
merged 1 commit into from
Aug 31, 2024
Merged

test(infra): improve e2e test stability #7713

merged 1 commit into from
Aug 31, 2024

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Aug 28, 2024 •
edited
Loading

Summary

closes #7683

It seems that the issue is caused by the CI attempting to perform a hot update on the index.js module, but the update fails because it is the entry module.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 28, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4129789
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cf0938f2eb9f0008887ac4

@shulaoda
Copy link
Collaborator Author

The first pipeline test passed, I will rebase and try again.

@shulaoda shulaoda force-pushed the fix/css-recovery-ci-error branch 2 times, most recently from 40d099d to 617c965 Compare August 28, 2024 09:55
@shulaoda shulaoda force-pushed the fix/css-recovery-ci-error branch from 617c965 to 4129789 Compare August 28, 2024 11:25
@hardfist hardfist requested a review from jerrykingxyz August 28, 2024 13:34
@chenjiahan chenjiahan changed the title feat(infra): improve e2e test stability test(infra): improve e2e test stability Aug 28, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label Aug 28, 2024
@fi3ework
Copy link
Member

But why does it only have a small probability of failure, and can only be reproduced in CI?

@shulaoda
Copy link
Collaborator Author

But why does it only have a small probability of failure, and can only be reproduced in CI?

I'm not sure yet.

chenjiahan
chenjiahan approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! hope the case will be stable after merging this 😄

@chenjiahan chenjiahan merged commit 39b7225 into web-infra-dev:main Aug 31, 2024
30 checks passed
@chenjiahan
Copy link
Member

If this doesn't resolve the issue, we can investigate further.

@shulaoda shulaoda deleted the fix/css-recovery-ci-error branch August 31, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infra: improve e2e test stability
3 participants
@shulaoda @fi3ework @chenjiahan