Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rspack-cli): enable rspack cli command serve basic test case #7724

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

It seems that the basic test case for the serve command is being skipped due to timeout or other reasons. We could try to terminate the test as soon as the relevant log information appears to achieve the intended testing purpose.

it.skip("should work", async () => {
const { stderr } = await runWatch(__dirname, ["serve"]);
// @todo current server implementation is too buggy to test
expect(normalizeStderr(stderr)).toBeTruthy;
});

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a005829
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66d032791df7d800080c3369

@h-a-n-a h-a-n-a merged commit 6b8b9b2 into web-infra-dev:main Aug 29, 2024
33 checks passed
@shulaoda shulaoda deleted the test/rspack-cli branch August 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants