Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-rspack): support for linter, formatter and CLI flags #7735

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat(create-rspack): support for linter, formatter and CLI flags #7735

merged 3 commits into from
Aug 30, 2024

Conversation

chenjiahan
Copy link
Member

Summary

  • Using create-rstack to create the new project, it is used by create-rsbuild and create-rslib too.
  • Using Rslib to build the create-rspack package.

New UI

before:

Screenshot 2024-08-30 at 13 58 12

after:

Screenshot 2024-08-30 at 14 39 20

Support for linter / formatter

Screenshot 2024-08-30 at 14 42 24

Support for CLI flags

Screenshot 2024-08-30 at 14 43 07

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 482ae1c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66d16cc94298e10008e1bb6d
😎 Deploy Preview https://deploy-preview-7735--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 30, 2024
@chenjiahan chenjiahan changed the title feat(create-rspack): support for linter and formatter feat(create-rspack): support for linter, formatter, CLI flags Aug 30, 2024
@chenjiahan chenjiahan changed the title feat(create-rspack): support for linter, formatter, CLI flags feat(create-rspack): support for linter, formatter and CLI flags Aug 30, 2024
@chenjiahan chenjiahan requested a review from hardfist August 30, 2024 07:00
@chenjiahan chenjiahan merged commit c1eac74 into main Aug 30, 2024
37 checks passed
@chenjiahan chenjiahan deleted the create_rspack_0830 branch August 30, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @hardfist