Skip to content

Commit

Permalink
Python3: Remove xfail for wpt unit tests in PY3 (#26202)
Browse files Browse the repository at this point in the history
Tests in test_wpt.py were marked as xfail due to virtualenv
activation issue (pypa/virtualenv#1710)
This issue has now been solved.
  • Loading branch information
ziransun authored Oct 21, 2020
1 parent 08d3be2 commit 35faa70
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tools/wpt/tests/test_wpt.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import errno
import os
import platform
import shutil
import socket
import subprocess
Expand Down Expand Up @@ -44,9 +43,6 @@ def get_persistent_manifest_path():

@pytest.fixture(scope="module", autouse=True)
def init_manifest():
# See https://github.com/pypa/virtualenv/issues/1710
if sys.version_info[0] >= 3 and platform.system() == "Windows":
pytest.xfail(reason="virtualenv activation fails in Windows for python3")
with pytest.raises(SystemExit) as excinfo:
wpt.main(argv=["manifest", "--no-download",
"--path", get_persistent_manifest_path()])
Expand Down

0 comments on commit 35faa70

Please sign in to comment.