-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIME Checks for link rel=manifest #24446
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c603606
Add MIME Checks for link rel=manifest
marcoscaceres ccfe67f
annotate as manual tests
marcoscaceres 51d763f
fix header file names
marcoscaceres c6078b8
Add invalid mimetype check
marcoscaceres b895983
Add missing Content-Type header check
marcoscaceres 2864fae
fix filenames to be -manual
marcoscaceres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (application/json)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="mime-type-application-json.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest valid (name is "pass"). The | ||
| response's Content-Type metadata is a JSON MIME type "application/json". | ||
| </p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "pass" | ||
| } |
1 change: 1 addition & 0 deletions
1
html/links/manifest/mime-type-application-json.webmanifest.headers
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Content-Type: application/json; charset=utf-8 |
10 changes: 10 additions & 0 deletions
10
html/links/manifest/mime-type-application-manifest+json-manual.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (application/manifest+json)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="mime-type-application-manifest+json.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest valid (name is "pass"). The | ||
| response's Content-Type metadata is a JSON MIME type | ||
| "application/manifest+json". | ||
| </p> |
3 changes: 3 additions & 0 deletions
3
html/links/manifest/mime-type-application-manifest+json.webmanifest
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "pass" | ||
| } |
1 change: 1 addition & 0 deletions
1
html/links/manifest/mime-type-application-manifest+json.webmanifest.headers
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Content-Type: application/manifest+json; charset=utf-8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (application/json)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="mime-type-invalid.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest as invalid. The | ||
| response's Content-Type metadata is an invalid mime type. | ||
| </p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "fail - invalid MIME type" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Content-Type: ׺°”˜`”°º× INVALID MIME TYPE ׺°”˜`”°º× |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (application/json)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="mime-type-invalid.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest as invalid. The | ||
| response's does not contain any Content-Type HTTP header. | ||
| </p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "fail - no Content-Type HTTP header" | ||
| } |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (text/json)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="mime-type-text-json.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest valid (name is "pass"). The | ||
| response's Content-Type metadata is a JSON MIME type "text/json". | ||
| </p> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "pass" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Content-Type: text/json; charset=utf-8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <title>Test JSON MIME Type support (text/plain)</title> | ||
| <link rel="help" href="https://html.spec.whatwg.org/#link-type-manifest" /> | ||
| <link rel="manifest" href="wrong-mime-type-text-plain.webmanifest.webmanifest" /> | ||
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest as not present. The response's | ||
| Content-Type metadata "text/plain" is <strong>NOT</strong> a JSON MIME type. | ||
| </p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "fail - MIME type is text/plain" | ||
| } |
1 change: 1 addition & 0 deletions
1
html/links/manifest/wrong-mime-type-text-plain.webmanifest.headers
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Content-Type: text/plain; charset=utf-8 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to test an "invalid" media type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea... will add an actual invalid type.