Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for VisibilityStateEntry #35620

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Add tests for VisibilityStateEntry #35620

merged 4 commits into from
Sep 7, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Aug 25, 2022

VisibilityStateEntry is a performance entry that lets you track changes to page visibility.
See whatwg/html#8206

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

}

return {minimize, restore};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: newline at the end so that GH won't complain?

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss
Copy link
Contributor

Maybe we should mark the tests as tentative, as I don't know this has consensus yet..

@noamr noamr enabled auto-merge (squash) September 7, 2022 14:21
@noamr noamr merged commit e42b3cd into master Sep 7, 2022
@noamr noamr deleted the page-vis-entry branch September 7, 2022 15:01
mirisuzanne added a commit to oddbird/wpt that referenced this pull request Sep 8, 2022
* master: (28 commits)
  Explicitly guard against cross-origin entry copy in NavigationApi::InitializeForNewWindow
  Remove doMathvariantStyling fallback from MathMLTextRunFactory.
  Ignore the computed "user-select" on editable elements
  Make -webkit-line-clamp create a block container in the appropriate situations.
  Clamp snap points inside the scroll range.
  Add epsilon allowance to transform-dynamic-update.html wpt as we pass it except for rounding.
  Fix success test cases in service-worker-update.https.window.js
  Return value instead of key from Stash example (web-platform-tests#35814)
  Rename .xhtml to .html and add the !doctype template
  [wdspec] Add tests for "browsingContext.load" event.
  [wdspec] Add test for script.disown
  [wdspec] Add support for script.disown in wdspec tests
  Add two new tests to make sure padding is correctly added to flex items (web-platform-tests#35714)
  Add displaySurface to navigator.mediaDevices.getSupportedConstraints()
  Deflake background-color-animation-with-blur.html
  Navigation-rewrite: Add unparseable URL redirect traversal test
  Add tests for `VisibilityStateEntry` (web-platform-tests#35620)
  [Post Message] (5) Fix test naming
  Disallow forgiving selector-parsing in @supports.
  Add accept-encoding:identity for range requests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants